[webkit-reviews] review granted: [Bug 71600] --webkit-visual-word crash when create legacy position for shadowRoot : [Attachment 113740] patch w/ layout test

[bugzilla-daemon at webkit.org]

Ryosuke Niwa <rniwa at webkit.org> has granted Xiaomei Ji <xji at chromium.org>'s
request for review:
Bug 71600: --webkit-visual-word crash when create legacy position for
shadowRoot
https://bugs.webkit.org/show_bug.cgi?id=71600

Attachment 113740: patch w/ layout test
https://bugs.webkit.org/attachment.cgi?id=113740&action=review

------- Additional Comments from Ryosuke Niwa <rniwa at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=113740&action=review


>
LayoutTests/editing/selection/move-by-word-visually-crash-test-textarea.html:4
> +    try {

Why do we need try?

>
LayoutTests/editing/selection/move-by-word-visually-crash-test-textarea.html:16

> +	   sel = window.getSelection();
> +	   sel.modify("move", "left", "-webkit-visual-word");
> +	   sel.modify("move", "left", "-webkit-visual-word");

This can be written as:
getSelection().modify("move", "left", "-webkit-visual-word");
getSelection().modify("move", "left", "-webkit-visual-word");