[webkit-reviews] review denied: [Bug 71903] [chromium] Missing wait() in CCThreadProxy::setVisible : [Attachment 114522] Added unit test, fixed setVisible(true)

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Nov 10 09:58:49 PST 2011


James Robinson <jamesr at chromium.org> has denied Iain Merrick
<husky at google.com>'s request for review:
Bug 71903: [chromium] Missing wait() in CCThreadProxy::setVisible
https://bugs.webkit.org/show_bug.cgi?id=71903

Attachment 114522: Added unit test, fixed setVisible(true)
https://bugs.webkit.org/attachment.cgi?id=114522&action=review

------- Additional Comments from James Robinson <jamesr at chromium.org>
Suppressing commits when not visible is an efficiency that we can't afford to
not have.

Should we pass visible state across explicitly instead of relying on
setNeedsCommit() / pushing in the commit?


More information about the webkit-reviews mailing list