[webkit-reviews] review granted: [Bug 65173] Use AtomicString as return value for SVGURIReference::getTarget() : [Attachment 101985] Patch

[bugzilla-daemon at webkit.org]

Brent Fulgham <bfulgham at webkit.org> has granted Patrick R. Gansterer
<paroga at paroga.com>'s request for review:
Bug 65173: Use AtomicString as return value for SVGURIReference::getTarget()
https://bugs.webkit.org/show_bug.cgi?id=65173

Attachment 101985: Patch
https://bugs.webkit.org/attachment.cgi?id=101985&action=review

------- Additional Comments from Brent Fulgham <bfulgham at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=101985&action=review


Looks good to me.  Build bots seem happy, so let's r+ it.

> Source/WebCore/ChangeLog:8
> +	   Use AtomicString instead of String to avoid unnecessary type
conversations.

I think you mean "type conversions" here. ;-)

> Source/WebCore/rendering/svg/SVGResources.cpp:142
>      if (element->hasTagName(SVGNames::patternTag))

It would be neat if the href calls in the implementation returned AtomicStrings
as well, but that would be a much bigger change!  :-)