[webkit-reviews] review granted: [Bug 71956] Cache and reuse HTMLCollections exposed by Document. : [Attachment 114504] Proposed patch

[bugzilla-daemon at webkit.org]

Antti Koivisto <koivisto at iki.fi> has granted Andreas Kling <kling at webkit.org>'s
request for review:
Bug 71956: Cache and reuse HTMLCollections exposed by Document.
https://bugs.webkit.org/show_bug.cgi?id=71956

Attachment 114504: Proposed patch
https://bugs.webkit.org/attachment.cgi?id=114504&action=review

------- Additional Comments from Antti Koivisto <koivisto at iki.fi>
View in context: https://bugs.webkit.org/attachment.cgi?id=114504&action=review


r=me

It would be good if we had more tests in this area. The fact that this affects
one test only is slightly discorncerning (though it does document the new
behavior).

> Source/WebCore/dom/Document.h:1429
> +    Vector<RefPtr<HTMLCollection>, NumCollectionTypes> m_collections;

I would just use plain array of RefPtrs here as the length is fixed.