[webkit-reviews] review denied: [Bug 72022] Web Inspector: [SuggestBox] Correctly position the box under the first character of the suggestion prefix. : [Attachment 114506] Patch

[bugzilla-daemon at webkit.org]

Pavel Feldman <pfeldman at chromium.org> has denied Alexander Pavlov (apavlov)
<apavlov at chromium.org>'s request for review:
Bug 72022: Web Inspector: [SuggestBox] Correctly position the box under the
first character of the suggestion prefix.
https://bugs.webkit.org/show_bug.cgi?id=72022

Attachment 114506: Patch
https://bugs.webkit.org/attachment.cgi?id=114506&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=114506&action=review


> Source/WebCore/inspector/front-end/TextPrompt.js:869
> +	* @param {*=} anchorBox

This is not nice.

> Source/WebCore/inspector/front-end/TextPrompt.js:884
> +	       anchorBox = this._anchorBox ||
this._inputElement.boxInWindow(window, this._parentElement);

This is a strange control flow: if given, use, otherwise check if it has been
used, otherwise do something.