[webkit-reviews] review canceled: [Bug 72000] [CMAKE] Add the UseV8.cmake to WebCore. : [Attachment 114440] Add the UseV8.cmake to WebCore to build bindings of V8 and generate JavaScript codes given IDL input.

[bugzilla-daemon at webkit.org]

Patrick R. Gansterer <paroga at paroga.com> has canceled jaehoon jeong
<jh4u.jeong at samsung.com>'s request for review:
Bug 72000: [CMAKE] Add the UseV8.cmake to WebCore.
https://bugs.webkit.org/show_bug.cgi?id=72000

Attachment 114440: Add the UseV8.cmake to WebCore to build bindings of V8 and
generate JavaScript codes given IDL input.
https://bugs.webkit.org/attachment.cgi?id=114440&action=review

------- Additional Comments from Patrick R. Gansterer <paroga at paroga.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=114440&action=review


> Source/WebCore/UseV8.cmake:19
> +    html/canvas/CanvasPixelArray.idl
> +
> +    storage/IDBVersionChangeEvent.idl
> +    storage/IDBVersionChangeRequest.idl

Are this IDL files part of V8? I don't think so. If you need them you should
put them into the CMakeLists.txt

> Source/WebCore/UseV8.cmake:23
> +    bindings/generic/BindingSecurityBase.cpp

If it's generic it should go into the CMakeLists.txt

> Source/WebCore/UseV8.cmake:25
> +    bindings/ScriptControllerBase.cpp

already included in CMakeLists.txt

> Source/WebCore/UseV8.cmake:240
> +ADD_CUSTOM_COMMAND(
> +    OUTPUT ${DERIVED_SOURCES_WEBCORE_DIR}/DebuggerScriptSource.h
> +    MAIN_DEPENDENCY bindings/v8/DebuggerScript.js
> +    COMMAND ${PERL_EXECUTABLE} ${WEBCORE_DIR}/inspector/xxd.pl
DebuggerScriptSource_js ${WEBCORE_DIR}/bindings/v8/DebuggerScript.js
${DERIVED_SOURCES_WEBCORE_DIR}/DebuggerScriptSource.h
> +    VERBATIM)

Please add all other dependencies too, not only the MAIN_DEPENDENCY.

> Source/WebCore/UseV8.cmake:256
> +ADD_CUSTOM_COMMAND(
> +    OUTPUT ${DERIVED_SOURCES_WEBCORE_DIR}/V8ArrayBufferViewCustomScript.h
> +    MAIN_DEPENDENCY bindings/v8/custom/V8ArrayBufferViewCustomScript.js
> +    COMMAND ${PERL_EXECUTABLE} ${WEBCORE_DIR}/inspector/xxd.pl
V8ArrayBufferViewCustomScript_js
${WEBCORE_DIR}/bindings/v8/custom/V8ArrayBufferViewCustomScript.js
${DERIVED_SOURCES_WEBCORE_DIR}/V8ArrayBufferViewCustomScript.h
> +    VERBATIM)

Missing dependecies?