[webkit-reviews] review granted: [Bug 71854] Access key should work on all elements : [Attachment 114441] Updated Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Nov 9 23:31:33 PST 2011


Adam Barth <abarth at webkit.org> has granted Vineet Chaudhary (vineetc)
<rgf748 at motorola.com>'s request for review:
Bug 71854: Access key should work on all elements
https://bugs.webkit.org/show_bug.cgi?id=71854

Attachment 114441: Updated Patch
https://bugs.webkit.org/attachment.cgi?id=114441&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=114441&action=review


> LayoutTests/fast/forms/access-key-for-all-elements.html:32
> +for (var i =0 ; i < test.length; i++) {
> +var parent = document.createElement(test[i]);
> +document.body.appendChild(parent);
> +var test_me = document.getElementsByTagName(test[i])[0];
> +debug('Check for ' + test_me.tagName + ' tag');
> +shouldBeDefined('test_me.accessKey');
> +test_me.accessKey ='k';
> +accesskey = test_me.accessKey; 
> +shouldBe('accesskey',"'k'");
> +debug('');
> +}

Please intent this code properly.


More information about the webkit-reviews mailing list