[webkit-reviews] review requested: [Bug 71854] Access key should work on all elements : [Attachment 114441] Updated Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Nov 9 22:56:29 PST 2011
Vineet Chaudhary (vineetc) <rgf748 at motorola.com> has asked for review:
Bug 71854: Access key should work on all elements
https://bugs.webkit.org/show_bug.cgi?id=71854
Attachment 114441: Updated Patch
https://bugs.webkit.org/attachment.cgi?id=114441&action=review
------- Additional Comments from Vineet Chaudhary (vineetc)
<rgf748 at motorola.com>
Thanks Adam/Ryosuke for inputs.
(In reply to comment #11)
> r- because there are redundant IDL attribute entries.
Removed redundant IDL attribute entries.
> >> LayoutTests/fast/forms/access-key-for-all-elements.html:8
> We need to test more than just div. I suggest you copy the list of elements
out of HTMLNames and test all elements in some loop.
Added more test coverage to all elements.
More information about the webkit-reviews
mailing list