[webkit-reviews] review granted: [Bug 71939] [MutationObservers] Microbenchmarks for appendChild, removeChild, and innerHTML : [Attachment 114335] Remove braces

[bugzilla-daemon at webkit.org]

Ojan Vafai <ojan at chromium.org> has granted Adam Klein <adamk at chromium.org>'s
request for review:
Bug 71939: [MutationObservers] Microbenchmarks for appendChild, removeChild,
and innerHTML
https://bugs.webkit.org/show_bug.cgi?id=71939

Attachment 114335: Remove braces
https://bugs.webkit.org/attachment.cgi?id=114335&action=review

------- Additional Comments from Ojan Vafai <ojan at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=114335&action=review


Looks fine. I have some personal stylistic nits that would make the code seem
more natural to me, but you can ignore them. I only listed them for the first
tests, but obviously the same nits apply to all the tests.

> PerformanceTests/Mutation/append-child-deep.html:23
> +    window.start = null;
> +    window.numRuns = 25;
> +    window.times = [];

Using "window." here seems weird to me. Just use start/numRuns/times. It'll do
the same thing right?

> PerformanceTests/Mutation/append-child-deep.html:32
> +	   var time = new Date().getTime() - start;

Nit: Use Date.now()

> PerformanceTests/Mutation/append-child-deep.html:43
> +	   start = new Date().getTime();

ditto