[webkit-reviews] review granted: [Bug 71982] Renovate ARMv7 assembler/macro-assembler : [Attachment 114413] Fix
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Nov 9 18:14:28 PST 2011
Geoffrey Garen <ggaren at apple.com> has granted Gavin Barraclough
<barraclough at apple.com>'s request for review:
Bug 71982: Renovate ARMv7 assembler/macro-assembler
https://bugs.webkit.org/show_bug.cgi?id=71982
Attachment 114413: Fix
https://bugs.webkit.org/attachment.cgi?id=114413&action=review
------- Additional Comments from Geoffrey Garen <ggaren at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=114413&action=review
r=me
> Source/JavaScriptCore/assembler/MacroAssemblerARMv7.h:332
> + void rshift32(RegisterID shift_amount, RegisterID dest)
shift_amount => shiftAmount is The WebKit Style (TM).
More information about the webkit-reviews
mailing list