[webkit-reviews] review requested: [Bug 71518] [Chromium] gamepad changes to the public interface of Chromium port : [Attachment 114345] whitespace

[bugzilla-daemon at webkit.org]

Scott Graham <scottmg at chromium.org> has asked  for review:
Bug 71518: [Chromium] gamepad changes to the public interface of Chromium port
https://bugs.webkit.org/show_bug.cgi?id=71518

Attachment 114345: whitespace
https://bugs.webkit.org/attachment.cgi?id=114345&action=review

------- Additional Comments from Scott Graham <scottmg at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=114345&action=review


>> Source/WebKit/chromium/public/WebGamepad.h:31
>> +// This structure is intentionally POD and fixed size so that it can be
shared
> 
> nit: "can be [stored in] shared"

Done.

>> Source/WebKit/chromium/public/WebGamepad.h:53
>> +	unsigned index;
> 
> i'm not entirely sure why this is needed.  why wouldn't you just leave holes
in WebGamepads?  or, is this so that you can avoid wasting storage space for
the holes?

Agreed, removed. (It was needed in a previous iteration that attempted to send
each pad separately so to know where to slot it.)