[webkit-reviews] review granted: [Bug 69703] HRTF Database consolidation : [Attachment 114344] Consolidate Composite azimuth/elevations in a single wav file

[bugzilla-daemon at webkit.org]

Kenneth Russell <kbr at google.com> has granted Philippe Normand
<pnormand at igalia.com>'s request for review:
Bug 69703: HRTF Database consolidation
https://bugs.webkit.org/show_bug.cgi?id=69703

Attachment 114344: Consolidate Composite azimuth/elevations in a single wav
file
https://bugs.webkit.org/attachment.cgi?id=114344&action=review

------- Additional Comments from Kenneth Russell <kbr at google.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=114344&action=review


Based on Chris's review, r=me, but one comment. Also, it's concerning that none
of the EWS bots handle this patch because of the wav file. I assume you'll
handle this somehow. Perhaps you could regenerate the patch via Subversion and
check it via EWS before committing it.

> Source/WebCore/platform/audio/HRTFElevation.cpp:90
> +#if PLATFORM(GTK)

Perhaps this and the PLATFORM(GTK) below could be hoisted to the top of the
file, and define a file-local symbol like USE_CONCATENATED_IMPULSE_RESPONSES?