[webkit-reviews] review granted: [Bug 71961] Make the Port object have a Host : [Attachment 114379] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Nov 9 15:38:14 PST 2011


Adam Barth <abarth at webkit.org> has granted Eric Seidel <eric at webkit.org>'s
request for review:
Bug 71961: Make the Port object have a Host
https://bugs.webkit.org/show_bug.cgi?id=71961

Attachment 114379: Patch
https://bugs.webkit.org/attachment.cgi?id=114379&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=114379&action=review


> Tools/Scripts/webkitpy/layout_tests/port/base.py:90
> +		    port_name=None, options=None,

Separate lines?

> Tools/Scripts/webkitpy/layout_tests/port/factory.py:126
> +	   host = host or self._host

I would have put this at the top of the function, but whatever.


More information about the webkit-reviews mailing list