[webkit-reviews] review granted: [Bug 71890] [GTK][DRT] window internals object is not reset after each test : [Attachment 114334] updated patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Nov 9 12:05:55 PST 2011


Martin Robinson <mrobinson at webkit.org> has granted Philippe Normand
<pnormand at igalia.com>'s request for review:
Bug 71890: [GTK][DRT] window internals object is not reset after each test
https://bugs.webkit.org/show_bug.cgi?id=71890

Attachment 114334: updated patch
https://bugs.webkit.org/attachment.cgi?id=114334&action=review

------- Additional Comments from Martin Robinson <mrobinson at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=114334&action=review


Thank you!

> Tools/DumpRenderTree/gtk/DumpRenderTree.cpp:727
> +    JSGlobalContextRef globalContext =
webkit_web_frame_get_global_context(mainFrame);
> +    WebCoreTestSupport::resetInternalsObject(globalContext);

Can probably just be one line.


More information about the webkit-reviews mailing list