[webkit-reviews] review denied: [Bug 71916] [chromium] scroll deltas are cleared during commit to the main thread : [Attachment 114280] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Nov 9 12:00:07 PST 2011


James Robinson <jamesr at chromium.org> has denied Hin-Chung Lam
<hclam at google.com>'s request for review:
Bug 71916: [chromium] scroll deltas are cleared during commit to the main
thread
https://bugs.webkit.org/show_bug.cgi?id=71916

Attachment 114280: Patch
https://bugs.webkit.org/attachment.cgi?id=114280&action=review

------- Additional Comments from James Robinson <jamesr at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=114280&action=review


> Source/WebCore/ChangeLog:15
> +	   Reviewed by NOBODY (OOPS!).

this line should go above the long-form patch description, directly below the
1-line desc and bug URL:

[chromium] Foo the blobbizer
https://bugs.webkit.org/show_bug.cgi?id=12345

Reviewed by NOBODY (OOPS!).

> Source/WebCore/ChangeLog:20
> +	     are unchanged during commit. And then after commit scroll delts
are

delts -> deltas

> Source/WebCore/platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:230
> +    if (!m_scrollLayerImpl || !scrollInfo.size())
> +	   return;
> +
> +    // FIXME: subtract scroll deltas from layer other than the root.
> +    ASSERT(scrollInfo.size() == 1 && scrollInfo[0].layerId ==
m_scrollLayerImpl->id());
> +    IntSize scrollDelta = scrollInfo[0].scrollDelta;

this whole part is still copy-pasted, and once we start applying scroll deltas
to more than the root layer this will be significantly larger.

> Source/WebCore/platform/graphics/chromium/cc/CCThreadProxy.cpp:414
> +    m_layerTreeHostImpl->subtractScrollDeltas(*scrollInfo.get());

just *scrollInfo, the .get() is noise


More information about the webkit-reviews mailing list