[webkit-reviews] review denied: [Bug 71887] [Qt] Enable geolocation by default : [Attachment 114240] Patch

[bugzilla-daemon at webkit.org]

Simon Hausmann <hausmann at webkit.org> has denied Kenneth Rohde Christiansen
<kenneth at webkit.org>'s request for review:
Bug 71887: [Qt] Enable geolocation by default
https://bugs.webkit.org/show_bug.cgi?id=71887

Attachment 114240: Patch
https://bugs.webkit.org/attachment.cgi?id=114240&action=review

------- Additional Comments from Simon Hausmann <hausmann at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=114240&action=review


I believe enabling this by default is going to break the build for setups where
the necessary dependencies are not installed, because the build system does not
automatically disable the feature again. The existing logic only covers
enabling it, if the corresponding qt module is found. It doesn't cover
disabling it if it's not found.

>> Tools/ChangeLog:1

> 
> ChangeLog entry has no bug number  [changelog/bugnumber] [5]

Style bot is correct here: There _is_ a bug, but it's not mentioned in
ChangeLog :)