[webkit-reviews] review denied: [Bug 70642] [QT] new API to get selection bounds for visibleSelection : [Attachment 114206] patch for selectionBounds() API

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Nov 9 11:52:36 PST 2011


Simon Hausmann <hausmann at webkit.org> has denied Srikumar B
<srikumar.b at gmail.com>'s request for review:
Bug 70642: [QT] new API to get selection bounds for visibleSelection
https://bugs.webkit.org/show_bug.cgi?id=70642

Attachment 114206: patch for selectionBounds() API
https://bugs.webkit.org/attachment.cgi?id=114206&action=review

------- Additional Comments from Simon Hausmann <hausmann at webkit.org>
I'm going to say r-.

    1) The function is declared virtual even though it is not designed to be
re-implemented.
    2) Adding virtual functions breaks binary compatibility (for no reason
here)
    3) In Qt, out parameters are usually pointer types and the function
signature starts with get.
    4) There is no unit test for this feature.

Can you elaborate what you're trying to do in your application? Why do you have
to retrieve three rectangles?

I think we need to understand your use-case better. But in general I'm hesitant
in adding new API to the WebKit "1" part of QtWebKit. We would like to consider
it "done" and avod adding new features.


More information about the webkit-reviews mailing list