[webkit-reviews] review denied: [Bug 71690] Add cc-bugs group to watch changes in chromium graphics : [Attachment 114319] create non-contributor account list and make check-webkit-style use the full account list

[bugzilla-daemon at webkit.org]

Eric Seidel <eric at webkit.org> has denied Dana Jansens <danakj at chromium.org>'s
request for review:
Bug 71690: Add cc-bugs group to watch changes in chromium graphics
https://bugs.webkit.org/show_bug.cgi?id=71690

Attachment 114319: create non-contributor account list and make
check-webkit-style use the full account list
https://bugs.webkit.org/attachment.cgi?id=114319&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=114319&action=review


> Tools/Scripts/webkitpy/common/config/committers.py:90
> +# This is a list of email addresses who have bugzilla accounts but are not

A list is not a "who", is it?

> Tools/Scripts/webkitpy/common/config/committers.py:95
> +    Contributor("Chromium Compositor Bugs", ["cc-bugs at google.com"],
"cc-bugs"),

This should be Account(...)

> Tools/Scripts/webkitpy/common/watchlist/watchlistparser.py:158
> -		   if not contributors.contributor_by_email(email):
> +		   if not accounts.account_by_email(email):
>		       cc_rule.remove_instruction(email)
>		       self._log_error("The email alias %s which is in the
watchlist is not listed as a contributor in committers.py" % email)
>		       continue

This code should additionally check that it's the first email, the
bugzilla_email in the account.	account_by_email will give you any account with
that email, which might not be the bugzilla email for the account.