[webkit-reviews] review granted: [Bug 71550] REGRESSION (r93614): Content remains despite parent element being scrolled off page using javascript. : [Attachment 114158] Fix 2: better table coverage, same code change, only Chromium-linux baseline.

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has granted Julien Chaffraix
<jchaffraix at webkit.org>'s request for review:
Bug 71550: REGRESSION (r93614): Content remains despite parent element being
scrolled off page using javascript.
https://bugs.webkit.org/show_bug.cgi?id=71550

Attachment 114158: Fix 2: better table coverage, same code change, only
Chromium-linux baseline.
https://bugs.webkit.org/attachment.cgi?id=114158&action=review

------- Additional Comments from Simon Fraser (smfr) <simon.fraser at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=114158&action=review


> Source/WebCore/rendering/RenderLayer.cpp:439
> +    if (flags & HasSeenFixedPositionedAncestor ||
renderer()->style()->position() == FixedPosition) {

Would prefer parens around flags & HasSeenFixedPositionedAncestor

> Source/WebCore/rendering/RenderLayer.cpp:448
> +    } else if (flags & HasSeenAncestorWithOverflowClip &&
!m_canSkipRepaintRectsUpdateOnScroll) {

Ditto

> Source/WebCore/rendering/RenderLayer.h:475
> +	   HasSeenFixedPositionedAncestor = 1 << 1,
> +	   HasSeenAncestorWithOverflowClip = 1 << 2

Should be 1 << 0 and 1 << 1