[webkit-reviews] review denied: [Bug 71244] CSS 2.1 failure: border-conflict-element-* : [Attachment 113924] Patch

[bugzilla-daemon at webkit.org]

Dave Hyatt <hyatt at apple.com> has denied Robert Hogan <robert at webkit.org>'s
request for review:
Bug 71244: CSS 2.1 failure: border-conflict-element-*
https://bugs.webkit.org/show_bug.cgi?id=71244

Attachment 113924: Patch
https://bugs.webkit.org/attachment.cgi?id=113924&action=review

------- Additional Comments from Dave Hyatt <hyatt at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=113924&action=review


> Source/WebCore/rendering/style/CollapsedBorderValue.h:44
> +	   , m_offsetFromStart(offsetFromStart)
> +	   , m_offsetFromTop(offsetFromTop)

Why not call these row and column offsets? Seems weird to use the terms
offsetFromStart and offsetFromTop when you just mean row and column position.

> Source/WebCore/rendering/style/CollapsedBorderValue.h:79
> +    int m_offsetFromStart;
> +    int m_offsetFromTop;

Shouldn't these be unsigned?