[webkit-reviews] review granted: [Bug 71875] Add code path in HashTable for emptyValueIsZero that does not require copying the empty value : [Attachment 114307] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Nov 9 10:09:10 PST 2011


Anders Carlsson <andersca at apple.com> has granted Darin Adler
<darin at apple.com>'s request for review:
Bug 71875: Add code path in HashTable for emptyValueIsZero that does not
require copying the empty value
https://bugs.webkit.org/show_bug.cgi?id=71875

Attachment 114307: Patch
https://bugs.webkit.org/attachment.cgi?id=114307&action=review

------- Additional Comments from Anders Carlsson <andersca at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=114307&action=review


> Source/JavaScriptCore/wtf/HashTable.h:642
> +	       // The memset to 0 looks like a slow operation is optimized by
the compilers.

Looks like a missing "but" here.


More information about the webkit-reviews mailing list