[webkit-reviews] review granted: [Bug 70877] [GTK] [WebKit] Replace the gtkdoc autools magic with something more flexible : [Attachment 114294] Patch

[bugzilla-daemon at webkit.org]

Philippe Normand <pnormand at igalia.com> has granted Martin Robinson
<mrobinson at webkit.org>'s request for review:
Bug 70877: [GTK] [WebKit] Replace the gtkdoc autools magic with something more
flexible
https://bugs.webkit.org/show_bug.cgi?id=70877

Attachment 114294: Patch
https://bugs.webkit.org/attachment.cgi?id=114294&action=review

------- Additional Comments from Philippe Normand <pnormand at igalia.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=114294&action=review


Ok! Just a last little remark. Thanks again for the efforts on this!

> Source/WebKit2/UIProcess/API/gtk/docs/gtkdoc.py:361
> +	   self._read_pkg_config_file(pkg_config_path)
> +
> +    def _read_pkg_config_file(self, pkg_config_path):

Oh sorry I missed that in previous review. Maybe you can do everything in the
constructor? Well a separate method is ok as well :)