[webkit-reviews] review granted: [Bug 71370] webkitdirs.pm: add getArchitecture implementation for autotools ports : [Attachment 114228] Patch

[bugzilla-daemon at webkit.org]

Xan Lopez <xan.lopez at gmail.com> has granted Andy Wingo <wingo at igalia.com>'s
request for review:
Bug 71370: webkitdirs.pm: add getArchitecture implementation for autotools
ports
https://bugs.webkit.org/show_bug.cgi?id=71370

Attachment 114228: Patch
https://bugs.webkit.org/attachment.cgi?id=114228&action=review

------- Additional Comments from Xan Lopez <xan.lopez at gmail.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=114228&action=review


> Tools/Scripts/webkitdirs.pm:254
> +	       # Fall back to output of `arch', if it is present.

Ultra nitpick, you don't really have further fallbacks, so I guess the "if it
is present" is a bit misleading. You'll use that or fail in some way I suppose.
Anyway, this looks OK to me.