[webkit-reviews] review granted: [Bug 71410] MediaControls should use MediaController if present. : [Attachment 114096] Patch

[bugzilla-daemon at webkit.org]

Eric Carlson <eric.carlson at apple.com> has granted Jer Noble
<jer.noble at apple.com>'s request for review:
Bug 71410: MediaControls should use MediaController if present.
https://bugs.webkit.org/show_bug.cgi?id=71410

Attachment 114096: Patch
https://bugs.webkit.org/attachment.cgi?id=114096&action=review

------- Additional Comments from Eric Carlson <eric.carlson at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=114096&action=review


> Source/WebCore/html/shadow/MediaControlElements.cpp:693
> +	   ExceptionCode code = 0;
> +	   mediaController()->setCurrentTime(max(0.0f,
mediaController()->currentTime() - 30), code);
>	   event->setDefaultHandled();

Nit: you ignore an exception so initialization isn't helpful.

> Source/WebCore/html/shadow/MediaControlElements.cpp:852
>      slider->setAttribute(maxAttr, "1");
> -    slider->setAttribute(valueAttr, String::number(mediaElement->volume()));

>      return slider.release();

Why does this no longer set the current value?

> Source/WebCore/html/shadow/MediaControlElements.cpp:902
>      slider->setAttribute(maxAttr, "1");
> -    slider->setAttribute(valueAttr, String::number(mediaElement->volume()));

>      return slider.release();

Ditto.