[webkit-reviews] review granted: [Bug 71811] Eliminate CSSMutableValue : [Attachment 114268] patch3

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Nov 9 07:14:41 PST 2011


Andreas Kling <kling at webkit.org> has granted Antti Koivisto <koivisto at iki.fi>'s
request for review:
Bug 71811: Eliminate CSSMutableValue
https://bugs.webkit.org/show_bug.cgi?id=71811

Attachment 114268: patch3
https://bugs.webkit.org/attachment.cgi?id=114268&action=review

------- Additional Comments from Andreas Kling <kling at webkit.org>
The change to parse-color-int-or-percent-crash.html looks good to me.
I agree that the color parsing routines are already covered well enough that
we're not losing anything of value here.
You missed changing the test to say "RGB color parser" instead of "length list
parser" though.

r+ based on Darin's original comments, and my love for this patch.


More information about the webkit-reviews mailing list