[webkit-reviews] review granted: [Bug 71823] Web Inspector: discard injected scripts upon front-end disconnect. : [Attachment 114259] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Nov 9 06:52:47 PST 2011


Yury Semikhatsky <yurys at chromium.org> has granted Pavel Feldman
<pfeldman at chromium.org>'s request for review:
Bug 71823: Web Inspector: discard injected scripts upon front-end disconnect.
https://bugs.webkit.org/show_bug.cgi?id=71823

Attachment 114259: Patch
https://bugs.webkit.org/attachment.cgi?id=114259&action=review

------- Additional Comments from Yury Semikhatsky <yurys at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=114259&action=review


> LayoutTests/http/tests/inspector-enabled/injected-script-discard.html:60
> +	       InspectorTest.evaluateInPage(error ? "console.log('Error
resolving object')" : "console.log('Resolved object successfully')", callback);


Please add FAILED: prefix to the failing branch so that the test is not
rebaselined by mistake.


More information about the webkit-reviews mailing list