[webkit-reviews] review denied: [Bug 71554] [Qt] 4 Layout test fail due to network error constant values clash with WebkitError enum values in FrameloaderclientQt : [Attachment 114238] Updated Patch

[bugzilla-daemon at webkit.org]

Simon Hausmann <hausmann at webkit.org> has denied Deepak Sherveghar
<bpwv64 at motorola.com>'s request for review:
Bug 71554: [Qt] 4 Layout test fail due to network error constant values clash
with WebkitError enum values in FrameloaderclientQt
https://bugs.webkit.org/show_bug.cgi?id=71554

Attachment 114238: Updated Patch
https://bugs.webkit.org/attachment.cgi?id=114238&action=review

------- Additional Comments from Simon Hausmann <hausmann at webkit.org>
The patch looks good (the right fix), but I'd prefer to replace the use of
DEFINE_STATIC_LOCAL with a straight comparision of the domains as string
literals.

The effort of unifying the string literals of the domains to a central place
can be a separate patch.

So r- for the DEFINE_STATIC_LOCAL, but otherwise I really appreciate that
you're fixing this rather nasty issue that is hard to find!