[webkit-reviews] review denied: [Bug 68251] clipPath does not work on foreignObject : [Attachment 114155] Patch

[bugzilla-daemon at webkit.org]

Dirk Schulze <krit at webkit.org> has denied Florin Malita <fmalita at google.com>'s
request for review:
Bug 68251: clipPath does not work on foreignObject
https://bugs.webkit.org/show_bug.cgi?id=68251

Attachment 114155: Patch
https://bugs.webkit.org/attachment.cgi?id=114155&action=review

------- Additional Comments from Dirk Schulze <krit at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=114155&action=review


It looks good for me in  general, I r- it because not only clip-path is
effected. I'd like to see masked and filtered FO examples as well. And one
example for opacity.

> Source/WebCore/ChangeLog:6
> +	   clipPath does not work on foreignObject
> +	   https://bugs.webkit.org/show_bug.cgi?id=68251
> +
> +	   Reviewed by NOBODY (OOPS!).

The change log needs to be more details. What have you done and why? This
should be included in the change log.

> Source/WebCore/rendering/svg/RenderSVGForeignObject.cpp:62
>      if (opacity < 1.0f)
>	   childPaintInfo.context->beginTransparencyLayer(opacity);

I think we do the opacity in SVGRenderSupport as well. Can you remove the calls
here and after your code please? Also, can you add a test to verify the
behavior please?

> Source/WebCore/rendering/svg/RenderSVGForeignObject.cpp:75
>      if (opacity < 1.0f)
>	   childPaintInfo.context->endTransparencyLayer();

(needs to be removed as well)