[webkit-reviews] review denied: [Bug 71792] Internals.markerRangeForNode should be able to take markers by specifying a marker type. : [Attachment 114211] Patch

[bugzilla-daemon at webkit.org]

MORITA Hajime <morrita at google.com> has denied Shinya Kawanaka
<shinyak at google.com>'s request for review:
Bug 71792: Internals.markerRangeForNode should be able to take markers by
specifying a marker type.
https://bugs.webkit.org/show_bug.cgi?id=71792

Attachment 114211: Patch
https://bugs.webkit.org/attachment.cgi?id=114211&action=review

------- Additional Comments from MORITA Hajime <morrita at google.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=114211&action=review


> Source/WebCore/testing/Internals.cpp:87
> +    

Could you propagate error to the caller and throw an exception for this?
Ignoring error here will make the troubleshooting hard.

Also, I want some way to specify "all". An empty string would be sufficient.

> LayoutTests/ChangeLog:10
> +	   * platform/chromium/test_expectations.txt: Skipped chromium tests.

Could you add skip entries for other ports?
I guess almost all other port uses test_expectations.txt. Only Apple windows
port uses Skipped file.