[webkit-reviews] review granted: [Bug 71873] Better abstract 'abs' operation through the MacroAssembler. : [Attachment 114194] Fixed typo in changelog.

[bugzilla-daemon at webkit.org]

Geoffrey Garen <ggaren at apple.com> has granted Gavin Barraclough
<barraclough at apple.com>'s request for review:
Bug 71873: Better abstract 'abs' operation through the MacroAssembler.
https://bugs.webkit.org/show_bug.cgi?id=71873

Attachment 114194: Fixed typo in changelog.
https://bugs.webkit.org/attachment.cgi?id=114194&action=review

------- Additional Comments from Geoffrey Garen <ggaren at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=114194&action=review


r=me

> Source/JavaScriptCore/runtime/JSGlobalData.cpp:92
> +const uint64_t MacroAssemblerX86Common::s_maskSignBit =
0x7FFFFFFFFFFFFFFFull;

I think I saw this line of code on Reddit once.

FFFFFFFFFFU!!