[webkit-reviews] review granted: [Bug 71523] De-virtualize JSObject::getOwnPropertyDescriptor : [Attachment 113716] Patch

[bugzilla-daemon at webkit.org]

Sam Weinig <sam at webkit.org> has granted Mark Hahnenberg
<mhahnenberg at apple.com>'s request for review:
Bug 71523: De-virtualize JSObject::getOwnPropertyDescriptor
https://bugs.webkit.org/show_bug.cgi?id=71523

Attachment 113716: Patch
https://bugs.webkit.org/attachment.cgi?id=113716&action=review

------- Additional Comments from Sam Weinig <sam at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=113716&action=review


> Source/JavaScriptCore/runtime/StringObject.h:33
> +	   virtual ~StringObject();

We tend to use a dummy virtual function (called dummyVirtual()) to anchor
instead of the destructor.

> Source/WebCore/bridge/runtime_method.h:40
> +    ~RuntimeMethod();

Same here.