[webkit-reviews] review granted: [Bug 71128] Select multiple options with mouse drag in Select element. : [Attachment 114136] Updated patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Nov 8 15:26:28 PST 2011


Ryosuke Niwa <rniwa at webkit.org> has granted Rakesh <rakesh.kn at motorola.com>'s
request for review:
Bug 71128: Select multiple options with mouse drag in Select element.
https://bugs.webkit.org/show_bug.cgi?id=71128

Attachment 114136: Updated patch
https://bugs.webkit.org/attachment.cgi?id=114136&action=review

------- Additional Comments from Ryosuke Niwa <rniwa at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=114136&action=review


> Source/WebCore/page/EventHandler.cpp:566
> +	   if (!(renderer && renderer->isListBox()))

It's probably simpler to write this as !renderer || !renderer->isListBox()


More information about the webkit-reviews mailing list