[webkit-reviews] review granted: [Bug 71579] Exposing getRect function in WebNode for chromium : [Attachment 114148] Patch

[bugzilla-daemon at webkit.org]

Darin Fisher (:fishd, Google) <fishd at chromium.org> has granted
csharp at chromium.org's request for review:
Bug 71579: Exposing getRect function in WebNode for chromium
https://bugs.webkit.org/show_bug.cgi?id=71579

Attachment 114148: Patch
https://bugs.webkit.org/attachment.cgi?id=114148&action=review

------- Additional Comments from Darin Fisher (:fishd, Google)
<fishd at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=114148&action=review


> Source/WebKit/chromium/public/WebNode.h:119
> +    // Note: This method only works properly after layout has occurred.

Given that we have the same comment on hasNonEmptyBoundingBox, I think it is OK
to
have the same comment here.

I'm wondering what it means to return document-relative coordinates the
Chromium.
I don't know that we have a good way on the Chromium side to map those
coordinates
to viewport coordinates.  As a result, I'm not sure what you would do with
these
coordinate values.  Are they meaningful to you when the node is contained
within a
scrolled page?	What about a node in an iframe that is scrolled, contained in a

page that is also scrolled?