[webkit-reviews] review granted: [Bug 71763] Add support for float[] and double[] to IDL bindings code generator : [Attachment 114095] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Nov 8 12:40:06 PST 2011
Adam Barth <abarth at webkit.org> has granted Scott Graham
<scottmg at chromium.org>'s request for review:
Bug 71763: Add support for float[] and double[] to IDL bindings code generator
https://bugs.webkit.org/show_bug.cgi?id=71763
Attachment 114095: Patch
https://bugs.webkit.org/attachment.cgi?id=114095&action=review
------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=114095&action=review
> Source/WebCore/bindings/v8/V8Binding.h:399
> + for (size_t i = 0; i < v8Array->Length(); ++i) {
Should we store the Length in a temporary? I'm not sure how expensive this
call is.
More information about the webkit-reviews
mailing list