[webkit-reviews] review denied: [Bug 71761] Towards 8 Bit Strings: Templatize JSC::Parser class by Lexer type : [Attachment 114117] Updated patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Nov 8 12:04:11 PST 2011


Oliver Hunt <oliver at apple.com> has denied Michael Saboff <msaboff at apple.com>'s
request for review:
Bug 71761: Towards 8 Bit Strings: Templatize JSC::Parser class by Lexer type
https://bugs.webkit.org/show_bug.cgi?id=71761

Attachment 114117: Updated patch
https://bugs.webkit.org/attachment.cgi?id=114117&action=review

------- Additional Comments from Oliver Hunt <oliver at apple.com>
Can you rename T to LexerType, also could you break out the Lexer<UChar>* to
OwnPtr<Lexer<UChar> > change into a separate patch? there's a bug covering that
leak that i'd like to keep separate


More information about the webkit-reviews mailing list