[webkit-reviews] review granted: [Bug 71840] Allow RenderView to have columns : [Attachment 114127] Allow RenderView to have columns when the Page requests pagination

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has granted mitz at webkit.org's
request for review:
Bug 71840: Allow RenderView to have columns
https://bugs.webkit.org/show_bug.cgi?id=71840

Attachment 114127: Allow RenderView to have columns when the Page requests
pagination
https://bugs.webkit.org/attachment.cgi?id=114127&action=review

------- Additional Comments from Simon Fraser (smfr) <simon.fraser at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=114127&action=review


> Source/WebCore/page/Page.h:264
> +	       unsigned gap;

What is 'gap' here?

> Source/WebCore/rendering/RenderBlock.cpp:4519
> +    bool destroyColumns = !requiresColumns(count);

destroyColumns doesn't seem like quite the right name; you only need to destroy
if you have some already.