[webkit-reviews] review granted: [Bug 71826] Web Inspector: [refactoring] remove a bunch of methods from JavaScriptSourceFrameDelegate : [Attachment 114101] Patch

[bugzilla-daemon at webkit.org]

Pavel Feldman <pfeldman at chromium.org> has granted Andrey Kosyakov
<caseq at chromium.org>'s request for review:
Bug 71826: Web Inspector: [refactoring] remove a bunch of methods from
JavaScriptSourceFrameDelegate
https://bugs.webkit.org/show_bug.cgi?id=71826

Attachment 114101: Patch
https://bugs.webkit.org/attachment.cgi?id=114101&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=114101&action=review


> Source/WebCore/inspector/front-end/JavaScriptSourceFrame.js:82
> +	   this._model.setScriptSource(this._uiSourceCode, newContent,
callback);

Nit: We could encapsulate setScriptSource in the uiSourceCode for convenience.

> Source/WebCore/inspector/front-end/JavaScriptSourceFrame.js:374
> +		   this._model.removeBreakpoint(this._uiSourceCode,
lineNumber);

A dozen of methods that now accept uiSourceCode as the first argument suggest
that they could be declared on that class.