[webkit-reviews] review denied: [Bug 71754] Indent command can insert block quote in non editable content : [Attachment 113979] fixes the bug

Tue Nov 8 10:00:01 PST 2011

Enrica Casucci <enrica at apple.com> has denied Ryosuke Niwa <rniwa at webkit.org>'s
request for review:
Bug 71754: Indent command can insert block quote in non editable content
https://bugs.webkit.org/show_bug.cgi?id=71754

Attachment 113979: fixes the bug
https://bugs.webkit.org/attachment.cgi?id=113979&action=review

------- Additional Comments from Enrica Casucci <enrica at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=113979&action=review

The patch doesnt cover every case. It would be nice to add more cases to the
test. Definitely the one I mentioned above and probably the case were the root
editable element is an inline.

> Source/WebCore/editing/CompositeEditCommand.cpp:796
> +    }

This code will not work in every case. If you have 
<body><div contenteditable><img><img></div></body> the blockquote will still be
inserted outside the div. I believe the correct test should be to check if
outer node is the root editable element.