[webkit-reviews] review denied: [Bug 71370] webkitdirs.pm: add getArchitecture implementation for autotools ports : [Attachment 114080] Patch

[bugzilla-daemon at webkit.org]

Martin Robinson <mrobinson at webkit.org> has denied Andy Wingo
<wingo at igalia.com>'s request for review:
Bug 71370: webkitdirs.pm: add getArchitecture implementation for autotools
ports
https://bugs.webkit.org/show_bug.cgi?id=71370

Attachment 114080: Patch
https://bugs.webkit.org/attachment.cgi?id=114080&action=review

------- Additional Comments from Martin Robinson <mrobinson at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=114080&action=review


> Tools/Scripts/webkitdirs.pm:250
> +	   determineConfigurationProductDir();
> +	   my $host_triple = `grep -E '^host = '
$configurationProductDir/GNUmakefile`;
> +	   $architecture = $1 if $host_triple =~ m/^host = ([^-]+)-/;

In the Mac case they first check the architecture set for the build and then if
it's not there, they fall back to the system architecture. I think you should
do the same here.