[webkit-reviews] review granted: [Bug 24093] Autofocus inputs don't always honor selector input:focus : [Attachment 114010] Patch for Adding test case

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Nov 8 07:09:07 PST 2011


Kent Tamura <tkent at chromium.org> has granted Kaustubh Atrawalkar
<kaustubh at motorola.com>'s request for review:
Bug 24093: Autofocus inputs don't always honor selector input:focus
https://bugs.webkit.org/show_bug.cgi?id=24093

Attachment 114010: Patch for Adding test case
https://bugs.webkit.org/attachment.cgi?id=114010&action=review

------- Additional Comments from Kent Tamura <tkent at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=114010&action=review


> LayoutTests/fast/forms/autofocus-input-css-style-change.html:18
> +if (window.layoutTestController) {
> +    layoutTestController.dumpAsText();
> +}
> +
> +var test = document.getElementById("test");
> +if (document.defaultView.getComputedStyle(test,
null).getPropertyValue('background-color') == "rgb(0, 128, 0)")
> +    result.innerHTML = "PASS";

The code style is consistent. The first if has {} for 1-line body, and the
second if has no {} for 1-line body.


More information about the webkit-reviews mailing list