[webkit-reviews] review granted: [Bug 71770] Web Inspector: display notification in the front-end when inspected worker terminates : [Attachment 114038] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Nov 8 04:49:03 PST 2011


Pavel Feldman <pfeldman at chromium.org> has granted Yury Semikhatsky
<yurys at chromium.org>'s request for review:
Bug 71770: Web Inspector: display notification in the front-end when inspected
worker terminates
https://bugs.webkit.org/show_bug.cgi?id=71770

Attachment 114038: Patch
https://bugs.webkit.org/attachment.cgi?id=114038&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=114038&action=review


> Source/WebCore/inspector/front-end/inspector.js:464
> +    WebInspector.log("disconnectFromBackend");

Please remove this trace.

> Source/WebCore/inspector/front-end/inspector.js:857
> +    WebInspector.log("frontendReused");

ditto

> Source/WebKit/chromium/public/WebDevToolsAgent.h:95
> +    WEBKIT_EXPORT static WebString createFrontendDisconnectedEvent();

disconnectEventAsText() ?


More information about the webkit-reviews mailing list