[webkit-reviews] review granted: [Bug 71355] [Qt] Merge QTouchWebView and QDesktopWebView into one class : [Attachment 113941] Patch

[bugzilla-daemon at webkit.org]

Simon Hausmann <hausmann at webkit.org> has granted Alexis Menard
<alexis.menard at openbossa.org>'s request for review:
Bug 71355: [Qt] Merge QTouchWebView and QDesktopWebView into one class
https://bugs.webkit.org/show_bug.cgi?id=71355

Attachment 113941: Patch
https://bugs.webkit.org/attachment.cgi?id=113941&action=review

------- Additional Comments from Simon Hausmann <hausmann at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=113941&action=review


r=me, but qdesktopwebview.cpp doesn't actually compile because it includes
QtDesktopWebPageProxy.h, which your patch removes. Replacing the include makes
it compile.

I'll fix this when landing it.

> Source/WebKit2/UIProcess/qt/QtWebPageProxy.cpp:824
> +void QtWebPageProxy::doneWithTouchEvent(const NativeWebTouchEvent& event,
bool wasEventHandled)
> +{

This function crashes when running the touch layout tests. I'll add the missing
m_interactionEngine null pointer check when landing it.

Please run the layout tests next time (with WebKitTestRunner) :)