[webkit-reviews] review denied: [Bug 64002] [Qt] Some tests are flaky with NRWT : [Attachment 114002] I have skipped 2 tests to solve this.

[bugzilla-daemon at webkit.org]

Csaba Osztrogonac <ossy at webkit.org> has denied Nandor Huszka
<Huszka.Nandor at stud.u-szeged.hu>'s request for review:
Bug 64002: [Qt] Some tests are flaky with NRWT
https://bugs.webkit.org/show_bug.cgi?id=64002

Attachment 114002: I have skipped 2 tests to solve this.
https://bugs.webkit.org/attachment.cgi?id=114002&action=review

------- Additional Comments from Csaba Osztrogonac <ossy at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=114002&action=review


It is better, but we need one more round.

> LayoutTests/ChangeLog:17
> +	   * platform/qt/Skipped:
> +	   http/tests/notifications/icon-does-not-exist.html
> +	   http/tests/xmlhttprequest/workers/abort-exception-assert.html
> +
> +	   * platform/qt/test_expectations.txt:

* platform/qt/Skipped: Skip culprit tests
 - http/tests/notifications/icon-does-not-exist.html
 - http/tests/xmlhttprequest/workers/abort-exception-assert.html

* platform/qt/test_expectations.txt: Unskip passing tests.

> LayoutTests/platform/qt/Skipped:2544
> +
> +# [Qt] These made 7 tests timeout
> +# https://bugs.webkit.org/show_bug.cgi?id=64002
> +# https://bugs.webkit.org/show_bug.cgi?id=71693
> +# https://bugs.webkit.org/show_bug.cgi?id=71695
> +http/tests/notifications/icon-does-not-exist.html
> +http/tests/xmlhttprequest/workers/abort-exception-assert.html
> +

I think these entries would be better:

# [Qt] http/tests/notifications/icon-does-not-exist.html makes
fast/notifications/notifications-click-event.html fail
# https://bugs.webkit.org/show_bug.cgi?id=71693
http/tests/notifications/icon-does-not-exist.html

# [Qt] http/tests/xmlhttprequest/workers/abort-exception-assert.html makes 6
fast/workers test fail
# https://bugs.webkit.org/show_bug.cgi?id=71695
http/tests/xmlhttprequest/workers/abort-exception-assert.html