[webkit-reviews] review denied: [Bug 71128] Select multiple options with mouse drag in Select element. : [Attachment 113337] Handling the specific case of allowing the autoscroll for parent node when the current node under mouse does not have renderer in case of select(parent) and option element.

[bugzilla-daemon at webkit.org]

Ryosuke Niwa <rniwa at webkit.org> has denied Rakesh <rakesh.kn at motorola.com>'s
request for review:
Bug 71128: Select multiple options with mouse drag in Select element.
https://bugs.webkit.org/show_bug.cgi?id=71128

Attachment 113337: Handling the specific case of allowing the autoscroll for
parent node when the current node under mouse does not have renderer in case of
select(parent) and option element.
https://bugs.webkit.org/attachment.cgi?id=113337&action=review

------- Additional Comments from Ryosuke Niwa <rniwa at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=113337&action=review


> Source/WebCore/page/EventHandler.cpp:561
> +	     || !(targetNode->renderer() ||
(targetNode->parentNode()->renderer() &&
targetNode->parentNode()->renderer()->isListBox())))

We should probably define a boolean here.

> Source/WebCore/page/EventHandler.cpp:573
> +	   if (!renderer && targetNode->parentNode()->renderer()->isListBox())

To avoid repeating the condition here.

> LayoutTests/fast/forms/select-multiple-elements-with-mouse-drag.html:9
> +window.jsTestIsAsync = true;
> +
> +function test() {

This test doesn't need to be async. r- because of this.

> LayoutTests/fast/forms/select-multiple-elements-with-mouse-drag.html:20
> +	   eventSender.mouseDown();
> +	   eventSender.mouseMoveTo(x, y + (optionHeight * 3));

You probably need leapForward here.