[webkit-reviews] review granted: [Bug 71596] WebKitMutationObserver.observe should raise a DOMException if passed invalid arguments : [Attachment 113923] Patch

[bugzilla-daemon at webkit.org]

Ryosuke Niwa <rniwa at webkit.org> has granted Adam Klein <adamk at chromium.org>'s
request for review:
Bug 71596: WebKitMutationObserver.observe should raise a DOMException if passed
invalid arguments
https://bugs.webkit.org/show_bug.cgi?id=71596

Attachment 113923: Patch
https://bugs.webkit.org/attachment.cgi?id=113923&action=review

------- Additional Comments from Ryosuke Niwa <rniwa at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=113923&action=review


> Source/WebCore/ChangeLog:9
> +	   exception:

Could you fit "exception:" on the previous line specially because the bug title
is already longer than the previous line?

> Source/WebCore/dom/WebKitMutationObserver.cpp:78
> +	   ec = NOT_FOUND_ERR;
> +	   return;
> +    }
> +
> +    if (!validateOptions(options)) {
> +	   ec = SYNTAX_ERR;

We should really agree which exceptions are thrown for each one of cases we're
throwing on public-webapps.

> Source/WebCore/dom/WebKitMutationObserver.h:51
> +typedef int ExceptionCode;
> +

Please include ExceptionCode.h instead. r=me provided this change.