[webkit-reviews] review canceled: [Bug 71758] URLs are encoded in UTF-8, then decoded as if they are Latin1 : [Attachment 113975] Patch

[bugzilla-daemon at webkit.org]

Benjamin Poulain <benjamin at webkit.org> has canceled Benjamin Poulain
<benjamin at webkit.org>'s request for review:
Bug 71758: URLs are encoded in UTF-8, then decoded as if they are Latin1
https://bugs.webkit.org/show_bug.cgi?id=71758

Attachment 113975: Patch
https://bugs.webkit.org/attachment.cgi?id=113975&action=review

------- Additional Comments from Benjamin Poulain <benjamin at webkit.org>
(In reply to comment #5)
> > As far as I can see, they are either all ASCII, or UTF-8. 
> > The encoding is done through KURL::init() in encodeRelativeString().
> 
> encodeRelativeString takes a TextEncoding argument, which can be an encoding
other than UTF-8 if the webpage is using an encoding other than UTF-8.

Hum, yep, I did not realize that was also added to the output. So we can
possibly have mixed encoding in the output.

That is getting tricky. I am tempted to change KURL::parse() to use a String
instead of a char*.