[webkit-reviews] review denied: [Bug 66837] Parse reftest.list and extract types of ref tests : [Attachment 113744] Fixed a bug in test_files

[bugzilla-daemon at webkit.org]

Ojan Vafai <ojan at chromium.org> has denied Ryosuke Niwa <rniwa at webkit.org>'s
request for review:
Bug 66837: Parse reftest.list and extract types of ref tests
https://bugs.webkit.org/show_bug.cgi?id=66837

Attachment 113744: Fixed a bug in test_files
https://bugs.webkit.org/attachment.cgi?id=113744&action=review

------- Additional Comments from Ojan Vafai <ojan at chromium.org>
As I said on webkit-dev, I'm not OK with generically adding manifest support.
If we're going to support reftest lists, they should be used exclusively for
test suites we import. So, I'd like to see this patch assume we'll import these
test suites to a certain directory (e.g. w3c) and only walk that subtree and if
that subtree has a reftest.list file, then it doesn't do the other walking of
that directory.