[webkit-reviews] review denied: [Bug 71753] IDL changes for gamepad support : [Attachment 113964] Patch

[bugzilla-daemon at webkit.org]

Adam Barth <abarth at webkit.org> has denied Scott Graham <scottmg at chromium.org>'s
request for review:
Bug 71753: IDL changes for gamepad support
https://bugs.webkit.org/show_bug.cgi?id=71753

Attachment 113964: Patch
https://bugs.webkit.org/attachment.cgi?id=113964&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=113964&action=review


> Source/WebCore/bindings/v8/custom/V8GamepadCustom.cpp:37
> +static v8::Handle<v8::Value> createNumberArray(const Gamepad::FloatVector&
vector)

You should teach the code generator how to do this instead of writing custom
bindings.  All custom bindings are fully of bugs.