[webkit-reviews] review denied: [Bug 70533] [Chromium] Cull occluded tiles in tiled layers : [Attachment 113897] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Nov 7 17:33:34 PST 2011


James Robinson <jamesr at chromium.org> has denied W. James MacLean
<wjmaclean at chromium.org>'s request for review:
Bug 70533: [Chromium] Cull occluded tiles in tiled layers
https://bugs.webkit.org/show_bug.cgi?id=70533

Attachment 113897: Patch
https://bugs.webkit.org/attachment.cgi?id=113897&action=review

------- Additional Comments from James Robinson <jamesr at chromium.org>
Agreeing with what everyone else has said - this needs to be broken up.

Also, what's the test strategy? Ideally I think you should be able to test
CCTiledCullerImpl (or whatever its name ends up being) in isolation, but it
looks like that would be pretty difficult to do with its current design.


More information about the webkit-reviews mailing list