[webkit-reviews] review granted: [Bug 71441] [Part 1] Parse the custom() function in -webkit-filter : [Attachment 113650] Patch V2

[bugzilla-daemon at webkit.org]

Dean Jackson <dino at apple.com> has granted Chiculita Alexandru
<achicu at adobe.com>'s request for review:
Bug 71441: [Part 1] Parse the custom() function in -webkit-filter
https://bugs.webkit.org/show_bug.cgi?id=71441

Attachment 113650: Patch V2
https://bugs.webkit.org/attachment.cgi?id=113650&action=review

------- Additional Comments from Dean Jackson <dino at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=113650&action=review


All good, as long as you fix the tests. Maybe have JS extract the url into just
the last component?

> LayoutTests/css3/filters/custom-filter-property-parsing-expected.txt:10
> +PASS declaration.getPropertyValue('-webkit-filter') is
'custom(url(file:///Volumes/SSD/Users/achicu/code/webkit/git/webkit/LayoutTests
/css3/filters/vertex.shader))'

This is going to break for everyone but you :)

> LayoutTests/css3/filters/custom-filter-property-parsing-expected.txt:16
> +PASS subRule.cssText is
'custom(url(file:///Volumes/SSD/Users/achicu/code/webkit/git/webkit/LayoutTests
/css3/filters/vertex.shader))'

ditto

> LayoutTests/css3/filters/custom-filter-property-parsing-expected.txt:27
> +PASS subRule.cssText is 'custom(none
url(file:///Volumes/SSD/Users/achicu/code/webkit/git/webkit/LayoutTests/css3/fi
lters/fragment.shader))'

ditto (and a couple more)

> Source/WebCore/css/CSSParser.cpp:6488
> +    // the implementation of the syntax:

Typically we don't put instructions like this, because it is obvious to anyone
editing the code.